LITE-28561 Implement sync PPR to marketplaces #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hairash
force-pushed
the
feature/LITE-28561-T2-Syns-PPR-to-Marketplaces
branch
from
1e3bade
to
ad99d14
Compare
Hairash
commented
Sep 26, 2023
connect_ext_ppr/tasks_manager.py
Outdated
| ) | ||
| .one_or_none() | ||
| ) | ||
| file_data = get_ppr_from_media( |
There was a problem hiding this comment.
I have a question here. Should we wrap it with the try..except block and raise a TaskException?
There was a problem hiding this comment.
Yes, I think that would be better
Hairash
commented
Sep 26, 2023
connect_ext_ppr/utils.py
Outdated
| else: | ||
| ws[col] = 'FALSE' | ||
| # This value updates here, because it is not convenient to return it | ||
| marketplaces_to_not_update.update(cbc_marketplace_ids_dict.values()) |
There was a problem hiding this comment.
I suppose, it is a bad pattern to return value this way, but didn't come up with how to do it better. Any ideas?
Hairash
force-pushed
the
feature/LITE-28561-T2-Syns-PPR-to-Marketplaces
branch
2 times, most recently
from
ac81597
to
818c2e8
Compare
|
|
Hairash
force-pushed
the
feature/LITE-28561-T2-Syns-PPR-to-Marketplaces
branch
2 times, most recently
from
f7f614f
to
29c3eb9
Compare
Hairash
force-pushed
the
feature/LITE-28561-T2-Syns-PPR-to-Marketplaces
branch
from
29c3eb9
to
9ab65b3
Compare
akodelia
approved these changes
Sep 27, 2023
connect_ext_ppr/tasks_manager.py
Outdated
| ) | ||
| .one_or_none() | ||
| ) | ||
| file_data = get_ppr_from_media( |
There was a problem hiding this comment.
Yes, I think that would be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.